From 35494bc81b59165ee9264cd1004bb05a120279a3 Mon Sep 17 00:00:00 2001 From: Martin Ashby Date: Thu, 28 Sep 2023 10:54:58 +0100 Subject: Reduce allocations, the message takes ownership of the bytes read from the stream and is responsible for deallocating, rather than copying them to their own storage. --- src/proto/ready_for_query.zig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/proto/ready_for_query.zig') diff --git a/src/proto/ready_for_query.zig b/src/proto/ready_for_query.zig index ef99e60..6bf25f9 100644 --- a/src/proto/ready_for_query.zig +++ b/src/proto/ready_for_query.zig @@ -14,10 +14,10 @@ const TransactionStatus = enum(u8) { transaction_status: TransactionStatus, -pub fn read(allocator: std.mem.Allocator, b: []const u8) !ReadyForQuery { - _ = allocator; - if (b.len != 1) return ProtocolError.InvalidMessageLength; - return .{ .transaction_status = enum_from_int(TransactionStatus, b[0]) orelse return ProtocolError.InvalidTransactionStatus }; +pub fn read(a: std.mem.Allocator, buf: []const u8) !ReadyForQuery { + defer a.free(buf); + if (buf.len != 1) return ProtocolError.InvalidMessageLength; + return .{ .transaction_status = enum_from_int(TransactionStatus, buf[0]) orelse return ProtocolError.InvalidTransactionStatus }; } pub fn write(self: ReadyForQuery, allocator: std.mem.Allocator, stream_writer: anytype) !void { _ = allocator; @@ -44,7 +44,6 @@ test "round trip" { try std.testing.expectEqual(Tag, tag); const len = try reader.readIntBig(u32); const buf = try allocator.alloc(u8, len - 4); - defer allocator.free(buf); try reader.readNoEof(buf); var sm2 = try ReadyForQuery.read(allocator, buf); defer sm2.deinit(allocator); -- cgit v1.2.3-ZIG