commit 7e25e4bbbd2fa4f919b9de33d2908c85b1c16e7b
parent 52081c99ea798b40380417cd6b87d830a022df1e
Author: gstraube <gstraube@mailbox.org>
Date: Mon, 8 Jan 2018 16:45:28 +0100
Extract hard-coded strings into resources
Signed-off-by: gstraube <gstraube@mailbox.org>
Diffstat:
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/app/src/main/java/com/github/cythara/MainActivity.java b/app/src/main/java/com/github/cythara/MainActivity.java
@@ -90,7 +90,7 @@ public class MainActivity extends AppCompatActivity implements ListenerFragment.
int checkedItem = useStandardNotation ? 0 : 1;
AlertDialog.Builder builder = new AlertDialog.Builder(this);
- builder.setTitle("Choose notation");
+ builder.setTitle(R.string.choose_notation);
builder.setSingleChoiceItems(R.array.notations, checkedItem,
new DialogInterface.OnClickListener() {
@Override
@@ -134,7 +134,7 @@ public class MainActivity extends AppCompatActivity implements ListenerFragment.
startRecording();
} else {
AlertDialog alertDialog = new AlertDialog.Builder(MainActivity.this).create();
- alertDialog.setTitle("Permission required");
+ alertDialog.setTitle(R.string.permission_required);
alertDialog.setMessage("Microphone permission is required. App will be closed");
alertDialog.setButton(AlertDialog.BUTTON_NEUTRAL, "OK",
new DialogInterface.OnClickListener() {
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -2,6 +2,8 @@
<string name="app_name">Cythara</string>
<string name="privacy_policy">Show privacy policy</string>
<string name="set_notation">Set notation</string>
+ <string name="choose_notation">Choose notation</string>
+ <string name="permission_required">Permission required</string>
<string-array name="tunings">
<item>Guitar (standard)</item>
<item>Guitar (Drop D)</item>